Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756685Ab0LHXCW (ORCPT ); Wed, 8 Dec 2010 18:02:22 -0500 Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:42074 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756548Ab0LHXCV convert rfc822-to-8bit (ORCPT ); Wed, 8 Dec 2010 18:02:21 -0500 MIME-Version: 1.0 In-Reply-To: <20101208222642.GA31802@kroah.com> References: <1291702146-17866-1-git-send-email-omar.ramirez@ti.com> <20101208222642.GA31802@kroah.com> Date: Wed, 8 Dec 2010 17:02:20 -0600 Message-ID: Subject: Re: [PATCH] staging: tidspbridge: remove file handling functions for loader From: "Ramirez Luna, Omar" To: Greg KH Cc: linux-omap , Ohad Ben-Cohen , Nishanth Menon , Felipe Contreras , Fernando Guzman Lugo , Armando Uribe De Leon , Greg Kroah-Hartman , Ernesto Ramos Falcon , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Rene Sapiens Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1758 Lines: 48 Hi, On Wed, Dec 8, 2010 at 4:26 PM, Greg KH wrote: > On Tue, Dec 07, 2010 at 12:09:06AM -0600, Omar Ramirez Luna wrote: >> Instead use request_firmware and friends to get a valid firmware >> image. >> >> Right now the image is supplied dynamically through udev and the >> following rule: >> >> KERNEL=="omap-dsp", SUBSYSTEM=="firmware", ACTION=="add", ? ? \ >> ? ? ? RUN+="/bin/sh -c 'echo 1 > /sys/$DEVPATH/loading; ? ? ? \ >> ? ? ? ? ? ? ? cat $FIRMWARE > /sys/$DEVPATH/data; ? ? ? ? ? ? \ >> ? ? ? ? ? ? ? echo 0 > /sys/$DEVPATH/loading'" > > Why do you need a custom firmware rule? It was meant as an example, when I compiled my minimal file system it didn't supply the firmware.sh script nor created /lib/firmware... I thought that not everybody would have the firmware.sh, so I just provided a sample rule. > ?Why doesn't the default firmware loading rule that comes with udev work properly for you? > What are you needing different here that works properly for all other drivers? firmware.sh under /lib/udev/ and dsp binaries installed under /lib/firmware/, my rule is the brute version of firmware.sh so nothing different in the script. Probably the only change would be to supply the firmware name only, as of now the insmod parameter requires the entire path, e.g.: insmod bridgedriver.ko base_img=/lib/dsp/baseimage.dof if using firmware.sh and placing firmware files under /lib/firmware/, then insmod bridgedriver.ko base_img=baseimage.dof Should be enough. Regards, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/