Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754308Ab0LHXf4 (ORCPT ); Wed, 8 Dec 2010 18:35:56 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:36059 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753955Ab0LHXfy (ORCPT ); Wed, 8 Dec 2010 18:35:54 -0500 Date: Wed, 8 Dec 2010 15:34:28 -0800 From: Randy Dunlap To: David Woodhouse Cc: Dmitry Torokhov , Corentin Chary , sedat.dilek@gmail.com, Matthew Garrett , LKML , platform-driver-x86@vger.kernel.org, Stephen Rothwell Subject: Re: linux-next: Tree for December 8 (drivers/platform/x86/Kconfig:422:error: recursive dependency detected!) Message-Id: <20101208153428.93c95c54.randy.dunlap@oracle.com> In-Reply-To: <1291849721.5992.145.camel@i7.infradead.org> References: <1291801990.5992.105.camel@i7.infradead.org> <20101208174603.GA7107@core.coreip.homeip.net> <20101208135105.a8482d46.randy.dunlap@oracle.com> <1291849721.5992.145.camel@i7.infradead.org> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 31 On Wed, 08 Dec 2010 23:08:39 +0000 David Woodhouse wrote: > On Wed, 2010-12-08 at 13:51 -0800, Randy Dunlap wrote: > > > > I dislike select, but reality is that modules do need to select/enable > > library code and minor features sometimes. > > > > OTOH, where drivers/platform/x86/Kconfig:ACPI_CMPC does "select INPUT" > > to enable an entire subsystem is wrong and bad IMO. > > This is just a deficiency in the tools. The correct answer is to fix the > damn tools, not invent this silly 'select' facility which means much the > same thing as 'depends on' but is implemented differently. > > As long ago as the mid-1990s, the Nemesis research OS was using a tcl > xconfig tool based on the Linux one, but which would show you the > dependencies for an option that was disabled, so you could enable them > where you needed to. Rather than just hiding the option completely. xconfig has options that show all symbols. I use that most of the time, but I bet that most people do not. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/