Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932300Ab0LICmJ (ORCPT ); Wed, 8 Dec 2010 21:42:09 -0500 Received: from mail.asbjorn.biz ([217.195.185.3]:47580 "EHLO mail.asbjorn.biz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932249Ab0LICmD (ORCPT ); Wed, 8 Dec 2010 21:42:03 -0500 From: Asbjoern Sloth Toennesen To: Jeff Kirsher Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] e1000e: cleanup: swap arguments to avoid checkpatch errors Date: Thu, 9 Dec 2010 02:40:56 +0000 Message-Id: <1291862457-16671-7-git-send-email-asbjorn@asbjorn.biz> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1291862457-16671-1-git-send-email-asbjorn@asbjorn.biz> References: <1291862457-16671-1-git-send-email-asbjorn@asbjorn.biz> To: Jeff Kirsher Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1861 Lines: 50 Swap argument order in order to avoid checkpatch treating it as an unary operation, instead of an binary one, and obtain consistency with the 3 other similar assignments in netdev.c (tdlen & rdlen). This patch fixes 3 checkpatch errors. Signed-off-by: Asbjoern Sloth Toennesen --- drivers/net/e1000e/netdev.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index bb6a1f5..bdd3774 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c @@ -2059,7 +2059,7 @@ int e1000e_setup_tx_resources(struct e1000_adapter *adapter) struct e1000_ring *tx_ring = adapter->tx_ring; int err = -ENOMEM, size; - size = sizeof(struct e1000_buffer) * tx_ring->count; + size = tx_ring->count * sizeof(struct e1000_buffer); tx_ring->buffer_info = vzalloc(size); if (!tx_ring->buffer_info) goto err; @@ -2094,7 +2094,7 @@ int e1000e_setup_rx_resources(struct e1000_adapter *adapter) struct e1000_buffer *buffer_info; int i, size, desc_len, err = -ENOMEM; - size = sizeof(struct e1000_buffer) * rx_ring->count; + size = rx_ring->count * sizeof(struct e1000_buffer); rx_ring->buffer_info = vzalloc(size); if (!rx_ring->buffer_info) goto err; @@ -2151,7 +2151,7 @@ static void e1000_clean_tx_ring(struct e1000_adapter *adapter) e1000_put_txbuf(adapter, buffer_info); } - size = sizeof(struct e1000_buffer) * tx_ring->count; + size = tx_ring->count * sizeof(struct e1000_buffer); memset(tx_ring->buffer_info, 0, size); memset(tx_ring->desc, 0, tx_ring->size); -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/