Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756683Ab0LIKnu (ORCPT ); Thu, 9 Dec 2010 05:43:50 -0500 Received: from mail-ww0-f42.google.com ([74.125.82.42]:34350 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756033Ab0LIKns (ORCPT ); Thu, 9 Dec 2010 05:43:48 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=DmWbZIM6vFAuC2mhVmzU4KeGmsSxKalW5QodgLxj5VxuZVv+U6qWvc6gH6DdeQ3mtk jWYTT3SMX1iYa2eVeu/Rdi5Us1e1FKD3AUTmYBdJOzeRl27OXA6f9U0oPHKjJoZufETc O4MZtY/kRTZH5t+D6JmcoD9yykE8DOGyq0aKE= Date: Thu, 9 Dec 2010 13:43:36 +0300 From: Dan Carpenter To: Marek Belisko Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] staging: ft1000: Convert char device to debugfs. Message-ID: <20101209104336.GT10623@bicker> Mail-Followup-To: Dan Carpenter , Marek Belisko , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1291890413-15255-1-git-send-email-marek.belisko@open-nandra.com> <1291890413-15255-2-git-send-email-marek.belisko@open-nandra.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291890413-15255-2-git-send-email-marek.belisko@open-nandra.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 460 Lines: 14 > + file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir, ^^^^^^^ > + NULL, &ft1000fops); Don't make this world writeable. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/