Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756259Ab0LIPua (ORCPT ); Thu, 9 Dec 2010 10:50:30 -0500 Received: from mga02.intel.com ([134.134.136.20]:29666 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753857Ab0LIPu1 (ORCPT ); Thu, 9 Dec 2010 10:50:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,320,1288594800"; d="scan'208";a="582149115" Date: Thu, 9 Dec 2010 16:50:22 +0100 From: Samuel Ortiz To: Sundar Iyer Cc: linux-arm-kernel@lists.infradead.org, dmitry.torokhov@gmail.com, ben-linux@fluff.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/20] mfd/tc3589x: undo gpio module reset during chip init Message-ID: <20101209155021.GW8884@sortiz-mobl> References: <1291388753-14662-1-git-send-email-sundar.iyer@stericsson.com> <1291388753-14662-13-git-send-email-sundar.iyer@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291388753-14662-13-git-send-email-sundar.iyer@stericsson.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1588 Lines: 52 Hi Sundar, On Fri, Dec 03, 2010 at 08:35:45PM +0530, Sundar Iyer wrote: > Skip putting the GPIO module into a reset during the chip init. This makes > sure to preserve any existing GPIO configurations done by pre-kernel boot code. > Acked-by: Samuel Ortiz Cheers, Samuel. > Signed-off-by: Sundar Iyer > --- > drivers/mfd/tc3589x.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c > index e173f33..fd206fd 100644 > --- a/drivers/mfd/tc3589x.c > +++ b/drivers/mfd/tc3589x.c > @@ -247,12 +247,15 @@ static int tc3589x_chip_init(struct tc3589x *tc3589x) > > dev_info(tc3589x->dev, "manufacturer: %#x, version: %#x\n", manf, ver); > > - /* Put everything except the IRQ module into reset */ > + /* > + * Put everything except the IRQ module into reset; > + * also spare the GPIO module for any pin initialization > + * done during pre-kernel boot > + */ > ret = tc3589x_reg_write(tc3589x, TC3589x_RSTCTRL, > TC3589x_RSTCTRL_TIMRST > | TC3589x_RSTCTRL_ROTRST > - | TC3589x_RSTCTRL_KBDRST > - | TC3589x_RSTCTRL_GPIRST); > + | TC3589x_RSTCTRL_KBDRST); > if (ret < 0) > return ret; > > -- > 1.7.2.dirty > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/