Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753105Ab0LIP4z (ORCPT ); Thu, 9 Dec 2010 10:56:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1125 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298Ab0LIP4x (ORCPT ); Thu, 9 Dec 2010 10:56:53 -0500 Date: Thu, 9 Dec 2010 10:20:33 -0500 From: Don Zickus To: Rakib Mullick Cc: Ingo Molnar , LKML , x86@kernel.org, Frederic Weisbecker Subject: Re: [PATCH] x86: Fix warning in hw_nmi.c Message-ID: <20101209152033.GU21786@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 28 On Thu, Dec 09, 2010 at 02:47:34PM +0600, Rakib Mullick wrote: > commit 0e2af2a9abf94b408ff70679b692a8644fed4aab fixed this warning, it > again introduced by commit 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a. > This patch fixes it by moving arch_trigger_all_cpu_backtrace few lines > above backtrace_mask's declaration. > > We were warned by the following warning: > > arch/x86/kernel/apic/hw_nmi.c:29: warning: ‘backtrace_mask’ defined but not used > > > Signed-off-by: Rakib Mullick Thanks Rakib. I already have this fix lined up for Ingo in another patch series. http://thread.gmane.org/gmane.linux.kernel/1069682/focus=1069960 Hopefully Ingo will get a chance to include it soon. Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/