Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753198Ab0LIQDE (ORCPT ); Thu, 9 Dec 2010 11:03:04 -0500 Received: from mail-iw0-f172.google.com ([209.85.214.172]:58524 "EHLO mail-iw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143Ab0LIQDD (ORCPT ); Thu, 9 Dec 2010 11:03:03 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=AmOWgwF4HHjCSHTh5A0zsaY+U2SlGAAc5b0Dm9M2JtBV/5Du37mrNe6YaJe2BglBZs jtKzMUv8QRRZQuV1W8Lu/GpcCacFLuoQXwyZT9U9Wf1lLQaRb9L9PCDCZu1fAixRugIc Ls+YX69aWlQCx0oQWrsFch4iy4KYOznLRQaBk= MIME-Version: 1.0 In-Reply-To: <20101209155925.GD1740@barrios-desktop> References: <1291893500-12342-1-git-send-email-mel@csn.ul.ie> <1291893500-12342-5-git-send-email-mel@csn.ul.ie> <20101209155925.GD1740@barrios-desktop> Date: Fri, 10 Dec 2010 01:03:01 +0900 Message-ID: Subject: Re: [PATCH 4/6] mm: kswapd: Reset kswapd_max_order and classzone_idx after reading From: Minchan Kim To: Mel Gorman Cc: Simon Kirby , KOSAKI Motohiro , Shaohua Li , Dave Hansen , Johannes Weiner , Andrew Morton , linux-mm , linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 33 On Fri, Dec 10, 2010 at 12:59 AM, Minchan Kim wrote: > On Thu, Dec 09, 2010 at 11:18:18AM +0000, Mel Gorman wrote: >> When kswapd wakes up, it reads its order and classzone from pgdat and >> calls balance_pgdat. While its awake, it potentially reclaimes at a high >> order and a low classzone index. This might have been a once-off that >> was not required by subsequent callers. However, because the pgdat >> values were not reset, they remain artifically high while >> balance_pgdat() is running and potentially kswapd enters a second >> unnecessary reclaim cycle. Reset the pgdat order and classzone index >> after reading. >> >> Signed-off-by: Mel Gorman > Reviewed-by: Minchan Kim Nitpick. Shouldn't this patch be merged with 1/6? > > -- > Kind regards, > Minchan Kim > -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/