Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754859Ab0LIRED (ORCPT ); Thu, 9 Dec 2010 12:04:03 -0500 Received: from mga09.intel.com ([134.134.136.24]:51067 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753944Ab0LIREB (ORCPT ); Thu, 9 Dec 2010 12:04:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,320,1288594800"; d="scan'208";a="685549628" Date: Thu, 9 Dec 2010 18:03:57 +0100 From: Samuel Ortiz To: Sundar Iyer Cc: linux-arm-kernel@lists.infradead.org, dmitry.torokhov@gmail.com, ben-linux@fluff.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/20] mfd/tc3589x: add suspend/resume support Message-ID: <20101209170356.GY8884@sortiz-mobl> References: <1291388753-14662-1-git-send-email-sundar.iyer@stericsson.com> <1291388753-14662-14-git-send-email-sundar.iyer@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291388753-14662-14-git-send-email-sundar.iyer@stericsson.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 27 Hi Sundar, On Fri, Dec 03, 2010 at 08:35:46PM +0530, Sundar Iyer wrote: Acked-by: Samuel Ortiz One remark though: > + > +static const struct dev_pm_ops tc3589x_dev_pm_ops = { > + .suspend = tc3589x_suspend, > + .resume = tc3589x_resume, > +}; > +#endif SIMPLE_DEV_PM_OPS or UNIVERSAL_DEV_PM_OPS may be useful and save one ifdef here. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/