Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756858Ab0LISOH (ORCPT ); Thu, 9 Dec 2010 13:14:07 -0500 Received: from canuck.infradead.org ([134.117.69.58]:58441 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756685Ab0LISNG (ORCPT ); Thu, 9 Dec 2010 13:13:06 -0500 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Frederic Weisbecker , Ian Munsie , Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 03/10] perf session: Dont queue events w/o timestamps Date: Thu, 9 Dec 2010 16:12:50 -0200 Message-Id: <1291918376-18261-4-git-send-email-acme@infradead.org> X-Mailer: git-send-email 1.6.2.5 In-Reply-To: <1291918376-18261-1-git-send-email-acme@infradead.org> References: <1291918376-18261-1-git-send-email-acme@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 40 From: Thomas Gleixner If the event has no timestamp assigned then the parse code sets it to ~0ULL which causes the ordering code to enqueue it at the end. Process it right away. Reported-by: Ian Munsie Cc: Frederic Weisbecker Cc: Ian Munsie Cc: Ingo Molnar Cc: Peter Zijlstra LKML-Reference: <20101207124550.528788441@linutronix.de> Signed-off-by: Thomas Gleixner Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/session.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index b3b145a..e5d0ed9 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -603,7 +603,7 @@ static int perf_session_queue_event(struct perf_session *s, event_t *event, u64 timestamp = data->time; struct sample_queue *new; - if (!timestamp) + if (!timestamp || timestamp == ~0ULL) return -ETIME; if (timestamp < s->ordered_samples.last_flush) { -- 1.6.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/