Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757101Ab0LIUEQ (ORCPT ); Thu, 9 Dec 2010 15:04:16 -0500 Received: from mail.perches.com ([173.55.12.10]:2387 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756981Ab0LIUEL (ORCPT ); Thu, 9 Dec 2010 15:04:11 -0500 From: Joe Perches To: netdev@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, rtc-linux@googlegroups.com, linux-s390@vger.kernel.org, osd-dev@open-osd.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Cc: Jiri Kosina , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org Subject: [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR Date: Thu, 9 Dec 2010 12:03:53 -0800 Message-Id: X-Mailer: git-send-email 1.7.3.3.464.gf80b6 In-Reply-To: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> References: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2669 Lines: 65 Tobias Klauser sent a patch to remove an unnecessary unlikely from drivers/misc/c2port/core.c, https://lkml.org/lkml/2010/12/9/199 Here are the other instances treewide. I think it'd be good if people would, when noticing defects in a specific subsystem, look for and correct the same defect treewide. IS_ERR already has an unlikely test so remove unnecessary unlikelys from the call sites. from: include/linux/err.h #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) [...] static inline long __must_check IS_ERR(const void *ptr) { return IS_ERR_VALUE((unsigned long)ptr); } Sending directly to maintainers for now, will resend in a month or so only to trivial if not picked up. Joe Perches (15): drm: Remove duplicate unlikely from IS_ERR stmmac: Remove duplicate unlikely from IS_ERR rtc: Remove duplicate unlikely from IS_ERR s390: Remove duplicate unlikely from IS_ERR osd: Remove duplicate unlikely from IS_ERR serial: Remove duplicate unlikely from IS_ERR brcm80211: Remove duplicate unlikely from IS_ERR gadget: Remove duplicate unlikely from IS_ERR exofs: Remove duplicate unlikely from IS_ERR ext2: Remove duplicate unlikely from IS_ERR ext3: Remove duplicate unlikely from IS_ERR ext4: Remove duplicate unlikely from IS_ERR nfs: Remove duplicate unlikely from IS_ERR mm: Remove duplicate unlikely from IS_ERR ipv6: Remove duplicate unlikely from IS_ERR drivers/gpu/drm/ttm/ttm_tt.c | 4 ++-- drivers/net/stmmac/stmmac_main.c | 2 +- drivers/rtc/rtc-bfin.c | 2 +- drivers/s390/scsi/zfcp_fsf.c | 4 ++-- drivers/scsi/osd/osd_initiator.c | 2 +- drivers/serial/msm_serial.c | 2 +- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 2 +- drivers/usb/gadget/f_fs.c | 4 ++-- fs/exofs/super.c | 2 +- fs/ext2/namei.c | 2 +- fs/ext3/namei.c | 2 +- fs/ext4/namei.c | 2 +- fs/nfs/mount_clnt.c | 2 +- mm/vmalloc.c | 2 +- net/ipv6/af_inet6.c | 2 +- 15 files changed, 18 insertions(+), 18 deletions(-) -- 1.7.3.3.464.gf80b6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/