Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757706Ab0LJBXr (ORCPT ); Thu, 9 Dec 2010 20:23:47 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:45528 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757246Ab0LJBXp (ORCPT ); Thu, 9 Dec 2010 20:23:45 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Fri, 10 Dec 2010 10:18:02 +0900 From: KAMEZAWA Hiroyuki To: Mel Gorman Cc: Simon Kirby , KOSAKI Motohiro , Shaohua Li , Dave Hansen , Johannes Weiner , Andrew Morton , linux-mm , linux-kernel Subject: Re: [PATCH 3/6] mm: kswapd: Use the order that kswapd was reclaiming at for sleeping_prematurely() Message-Id: <20101210101802.81b04765.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1291893500-12342-4-git-send-email-mel@csn.ul.ie> References: <1291893500-12342-1-git-send-email-mel@csn.ul.ie> <1291893500-12342-4-git-send-email-mel@csn.ul.ie> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 21 On Thu, 9 Dec 2010 11:18:17 +0000 Mel Gorman wrote: > Before kswapd goes to sleep, it uses sleeping_prematurely() to check if > there was a race pushing a zone below its watermark. If the race > happened, it stays awake. However, balance_pgdat() can decide to reclaim > at a lower order if it decides that high-order reclaim is not working as > expected. This information is not passed back to sleeping_prematurely(). > The impact is that kswapd remains awake reclaiming pages long after it > should have gone to sleep. This patch passes the adjusted order to > sleeping_prematurely and uses the same logic as balance_pgdat to decide > if it's ok to go to sleep. > > Signed-off-by: Mel Gorman Reviewed-by: KAMEZAWA Hiroyuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/