Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755092Ab0LJKgq (ORCPT ); Fri, 10 Dec 2010 05:36:46 -0500 Received: from mailfw02.zoner.fi ([84.34.147.249]:13650 "EHLO mailfw02.zoner.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698Ab0LJKgo (ORCPT ); Fri, 10 Dec 2010 05:36:44 -0500 From: Lasse Collin To: Phillip Lougher Subject: Re: [PATCH 2/2] Squashfs: Add XZ compression configuration option Date: Fri, 10 Dec 2010 12:37:23 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.36-ARCH; KDE/4.5.4; x86_64; ; ) Cc: Linux Kernel Development , linux-fsdevel@vger.kernel.org, Linux Embedded Maillist References: <4D007315.1090704@lougher.demon.co.uk> <201012091109.32084.lasse.collin@tukaani.org> <4D01D70A.5050508@lougher.demon.co.uk> In-Reply-To: <4D01D70A.5050508@lougher.demon.co.uk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201012101237.23379.lasse.collin@tukaani.org> X-Antivirus-Scanner: Clean mail though you should still use an Antivirus Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1560 Lines: 38 On 2010-12-10 Phillip Lougher wrote: > Lasse Collin wrote: > > On 2010-12-09 Phillip Lougher wrote: > >> +config SQUASHFS_XZ > >> + bool "Include support for XZ compressed file systems" > >> + depends on SQUASHFS > >> + default n > >> + select XZ_DEC > > > > Should "select XZ_DEC" be replaced with "depends on XZ_DEC"? XZ_DEC > > requires CRC32, so if "select XZ_DEC" is used, there needs to be > > also "select CRC32". > > XZ_DEC selects CRC32, kbuild handles these nested selects quite > happily, so if something selects XZ_DEC it knows it has to also > select CRC32. OK, I had misunderstood the notice about "select" and dependencies in Documentation/kbuild/kconfig-language.txt. > Depends on has quite different semantics to selects. If SQUASHFS_XZ > was made to depend on XZ_DEC then the option simply won't appear > unless the user knew to select XZ_DEC first (as it's default n). > This would prove extremely confusing, and probably lead to most > people thinking Squashfs didn't have XZ support, which is somewhat > undesirable. Good point. I always keep the inactive options visible in xconfig so I missed this. I will need to update my XZ boot-time support patch to use "select" instead of "depends on" too. Thanks! -- Lasse Collin | IRC: Larhzu @ IRCnet & Freenode -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/