Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138Ab0LJKnN (ORCPT ); Fri, 10 Dec 2010 05:43:13 -0500 Received: from gir.skynet.ie ([193.1.99.77]:49188 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563Ab0LJKnM (ORCPT ); Fri, 10 Dec 2010 05:43:12 -0500 Date: Fri, 10 Dec 2010 10:42:54 +0000 From: Mel Gorman To: Minchan Kim Cc: Simon Kirby , KOSAKI Motohiro , Shaohua Li , Dave Hansen , Johannes Weiner , Andrew Morton , linux-mm , linux-kernel Subject: Re: [PATCH 4/6] mm: kswapd: Reset kswapd_max_order and classzone_idx after reading Message-ID: <20101210104254.GL20133@csn.ul.ie> References: <1291893500-12342-1-git-send-email-mel@csn.ul.ie> <1291893500-12342-5-git-send-email-mel@csn.ul.ie> <20101209155925.GD1740@barrios-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 31 On Fri, Dec 10, 2010 at 01:03:01AM +0900, Minchan Kim wrote: > On Fri, Dec 10, 2010 at 12:59 AM, Minchan Kim wrote: > > On Thu, Dec 09, 2010 at 11:18:18AM +0000, Mel Gorman wrote: > >> When kswapd wakes up, it reads its order and classzone from pgdat and > >> calls balance_pgdat. While its awake, it potentially reclaimes at a high > >> order and a low classzone index. This might have been a once-off that > >> was not required by subsequent callers. However, because the pgdat > >> values were not reset, they remain artifically high while > >> balance_pgdat() is running and potentially kswapd enters a second > >> unnecessary reclaim cycle. Reset the pgdat order and classzone index > >> after reading. > >> > >> Signed-off-by: Mel Gorman > > Reviewed-by: Minchan Kim > > Nitpick. > Shouldn't this patch be merged with 1/6? > I don't think so as it's a standalone fix. For example, if this was merged on its own, the "order" should still be reset after reading. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/