DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Reply-To:Subject:To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=N5pfNAVeiZqlb9+jsj5NGnuuDgY9TlWXo83p0CKi4HRHpaEmggOZDBLeyXR0NK7+bAJmfpLDrMR28scpVv1g6X+Oiz7lwOnS7xl9Q+ZgX83ptk4tMccrqF0WfqQr8SCILGtuHtP7juiAawOsURhFUlsIQ6IANPeQCpZXHmbzj4I=;
Message-ID: <823199.4758.qm@web31810.mail.mud.yahoo.com>
Date: Fri, 10 Dec 2010 02:49:53 -0800 (PST)
From: Luben Tuikov <ltuikov@yahoo.com>
Reply-To: ltuikov@yahoo.com
Subject: Re: [PATCH] [USB] UAS: Use kzalloc instead of kmalloc
To: Greg KH <greg@kroah.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        willy@linux.intel.com
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2185
Lines: 68

Patch retracted for this still-born driver. Instead please use superior uasp.c which was recently submitted.

--- On Wed, 10/27/10, Luben Tuikov <ltuikov@yahoo.com> wrote:

> From: Luben Tuikov <ltuikov@yahoo.com>
> Subject: [PATCH] [USB] UAS: Use kzalloc instead of kmalloc
> To: "Greg KH" <greg@kroah.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, willy@linux.intel.com
> Date: Wednesday, October 27, 2010, 1:22 PM
> "Be conservative in what you send,
> liberal in what
> you accept." -- In the spirit of this adage, don't
> send Command IUs with randomly filled in data in
> the reserved fields. (Yes, this shows up on the
> wire.)
> 
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
>  drivers/usb/storage/uas.c |? ? 6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/storage/uas.c
> b/drivers/usb/storage/uas.c
> index 2054b1e..17e1820 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -294,7 +294,7 @@ static struct urb
> *uas_alloc_sense_urb(struct uas_dev_info *devinfo, gfp_t
> gfp,
>  ??? if (!urb)
>  ??? ??? goto out;
>  
> -??? iu = kmalloc(sizeof(*iu), gfp);
> +??? iu = kzalloc(sizeof(*iu), gfp);
>  ??? if (!iu)
>  ??? ??? goto free;
>  
> @@ -325,7 +325,7 @@ static struct urb
> *uas_alloc_cmd_urb(struct uas_dev_info *devinfo, gfp_t gfp,
>  ??? if (len < 0)
>  ??? ??? len = 0;
>  ??? len = ALIGN(len, 4);
> -??? iu = kmalloc(sizeof(*iu) + len, gfp);
> +??? iu = kzalloc(sizeof(*iu) + len, gfp);
>  ??? if (!iu)
>  ??? ??? goto free;
>  
> @@ -660,7 +660,7 @@ static int uas_probe(struct
> usb_interface *intf, const struct usb_device_id *id)
>  ??? ??? ???
> return -ENODEV;
>  ??? }
>  
> -??? devinfo = kmalloc(sizeof(struct
> uas_dev_info), GFP_KERNEL);
> +??? devinfo = kzalloc(sizeof(struct
> uas_dev_info), GFP_KERNEL);
>  ??? if (!devinfo)
>  ??? ??? return -ENOMEM;
>  
> -- 
> 1.7.0.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/