Subject: Re: [PATCH] LEDs: fix check for return value of blink_set callback
From: Richard Purdie <rpurdie@linux.intel.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>, akpm <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <1291975133-25671-1-git-send-email-anarsoul@gmail.com>
References: <1291975133-25671-1-git-send-email-anarsoul@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 10 Dec 2010 14:43:56 +0000
Message-ID: <1291992236.14420.3.camel@rex>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1176
Lines: 33

On Fri, 2010-12-10 at 11:58 +0200, Vasily Khoruzhick wrote:
> blink_set callback should return 0 on success, but check in
> led-class.c is invalid. It results in software fallback even if
> hw support is available.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Acked-by: Richard Purdie <rpurdie@linux.intel.com>

> ---
>  drivers/leds/led-class.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 211e21f..d5a4ade 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -267,7 +267,7 @@ void led_blink_set(struct led_classdev *led_cdev,
>  		   unsigned long *delay_off)
>  {
>  	if (led_cdev->blink_set &&
> -	    led_cdev->blink_set(led_cdev, delay_on, delay_off))
> +	    !led_cdev->blink_set(led_cdev, delay_on, delay_off))
>  		return;
>  
>  	/* blink with 1 Hz as default if nothing specified */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/