Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756627Ab0LJSKf (ORCPT ); Fri, 10 Dec 2010 13:10:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60958 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935Ab0LJSKe (ORCPT ); Fri, 10 Dec 2010 13:10:34 -0500 Date: Fri, 10 Dec 2010 10:04:00 -0800 From: Greg KH To: Dave Jones , Dan Carpenter , Marek Belisko , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Andy Whitcroft , Andrew Morton Subject: Re: [PATCH 1/8] staging: ft1000: Convert char device to debugfs. Message-ID: <20101210180400.GB12085@suse.de> References: <1291890413-15255-1-git-send-email-marek.belisko@open-nandra.com> <1291890413-15255-2-git-send-email-marek.belisko@open-nandra.com> <20101209104336.GT10623@bicker> <20101210173533.GB2505@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101210173533.GB2505@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 25 On Fri, Dec 10, 2010 at 12:35:33PM -0500, Dave Jones wrote: > On Thu, Dec 09, 2010 at 01:43:36PM +0300, Dan Carpenter wrote: > > > + file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir, > > ^^^^^^^ > > > + NULL, &ft1000fops); > > > > Don't make this world writeable. > > we should probably make checkpatch catch this. > > > > > Exporting world writable sysfs/debugfs files is usually a bad thing. > Warn about it. > > Signed-off-by: Dave Jones Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/