Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756896Ab0LJTlI (ORCPT ); Fri, 10 Dec 2010 14:41:08 -0500 Received: from kroah.org ([198.145.64.141]:39644 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756856Ab0LJTlG (ORCPT ); Fri, 10 Dec 2010 14:41:06 -0500 Date: Fri, 10 Dec 2010 11:36:37 -0800 From: Greg KH To: Bart Van Assche Cc: Vladislav Bolkhovitin , "linux-scsi@vger.kernel.org" , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , scst-devel Subject: Re: [Scst-devel] [PATCH 8/19]: SCST SYSFS interface implementation Message-ID: <20101210193637.GA23113@kroah.com> References: <20101115161620.GB5981@kroah.com> <4CE16B8E.1000300@panasas.com> <8985DEAF-4227-4629-B90A-938D2BA3534E@etechsoft.com> <4CE2846C.6070501@vlnb.net> <4CE59482.3050002@gmail.com> <20101118214619.GA29097@kroah.com> <4CE6BB4A.5060606@gmail.com> <20101119211904.GB28606@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 20 On Fri, Dec 10, 2010 at 01:06:06PM +0100, Bart Van Assche wrote: > On Fri, Nov 19, 2010 at 10:19 PM, Greg KH wrote: > > [ ... ] > > > > None. ?Use 'struct device' > > How about using 'struct device' as follows ? > * Move /sys/kernel/scst_tgt/targets to /sys/class/target_driver. Please never create a new class, use 'struct bus_type' instead and create a bus and have drivers and devices on it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/