Subject: Re: [RFC][PATCH 02/10] mm: Remove likely() from
 mapping_unevictable()
From: Steven Rostedt <rostedt@goodmis.org>
To: Miles Bader <miles@gnu.org>
Cc: Joe Perches <joe@perches.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nick Piggin <npiggin@kernel.dk>, Rik van Riel <riel@redhat.com>,
        Lee Schermerhorn <Lee.Schermerhorn@hp.com>
In-Reply-To: <buok4jikq3e.fsf@dhlpc061.dev.necel.com>
References: <20101207021328.569328536@goodmis.org>
	 <1291688533.16223.119.camel@gandalf.stny.rr.com>
	 <20101210160115.C7C4.A69D9226@jp.fujitsu.com>
	 <1291964792.24978.3.camel@Joe-Laptop>
	 <buok4jikq3e.fsf@dhlpc061.dev.necel.com>
Content-Type: text/plain; charset="ISO-8859-15"
Date: Fri, 10 Dec 2010 19:09:12 -0500
Message-ID: <1292026152.5015.1541.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 29

On Fri, 2010-12-10 at 17:08 +0900, Miles Bader wrote:
> Joe Perches <joe@perches.com> writes:
> > It'd be better to use
> >
> > 	if (!mapping)
> > 		return 0;
> > 	return test_bit(AS_UNEVICTABLE, &mapping->flags);
> >
> > to avoid the unnecessary !!
> 
> How about 
> 
>  	return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags);
> 
> instead...?

I'll just add my current patch as a "likely()" clean up. Any other
change should be separate.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/