Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428Ab0LLQCr (ORCPT ); Sun, 12 Dec 2010 11:02:47 -0500 Received: from mail7.hitachi.co.jp ([133.145.228.42]:46181 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753365Ab0LLQCo (ORCPT ); Sun, 12 Dec 2010 11:02:44 -0500 X-AuditID: b753bd60-a69a5ba000003e7d-6c-4d04f2217d82 Message-ID: <4D04F21D.6060300@hitachi.com> Date: Mon, 13 Dec 2010 01:02:37 +0900 From: Masami Hiramatsu Organization: Systems Development Lab., Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Franck Bui-Huu , 2nddept-manager@sdl.hitachi.co.jp, Francis Moreau , Franck Bui-Huu , Arnaldo Carvalho de Melo Subject: Re: [PATCH 2/2] perf symbols: Stop using vmlinux files with no symbols References: <1292167014-20936-1-git-send-email-acme@infradead.org> <1292167014-20936-3-git-send-email-acme@infradead.org> In-Reply-To: <1292167014-20936-3-git-send-email-acme@infradead.org> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== X-FMFTCR: RANGEC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1700 Lines: 47 (2010/12/13 0:16), Arnaldo Carvalho de Melo wrote: > From: Franck Bui-Huu > > Fail if the kernel image contains no symbol, allowing using other images > in the vmlinux search path that may have a usable symtab. > > Cc: 2nddept-manager@sdl.hitachi.co.jp > Cc: Francis Moreau > Cc: Franck Bui-Huu > Cc: Masami Hiramatsu > LPU-Reference: > Signed-off-by: Franck Bui-Huu > Signed-off-by: Arnaldo Carvalho de Melo Looks good for me:) Acked-by: Masami Hiramatsu > --- > tools/perf/util/probe-event.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index b71acd6..61191c6 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -135,7 +135,7 @@ const char *kernel_get_module_path(const char *module) > if (dso__load_vmlinux(dso, map, vmlinux_name, NULL) <= 0) > return NULL; > } else { > - if (dso__load_vmlinux_path(dso, map, NULL) < 0) { > + if (dso__load_vmlinux_path(dso, map, NULL) <= 0) { > pr_debug("Failed to load kernel map.\n"); > return NULL; > } -- Masami HIRAMATSU 2nd Dept. Linux Technology Center Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/