Subject: Re: [PATCH 3/3] Staging: rt2860: include KERN_* in printk
From: Joe Perches <joe@perches.com>
To: "L. Alberto" =?ISO-8859-1?Q?Gim=E9nez?= <agimenez@sysvalve.es>
Cc: devel@linuxdriverproject.org, Greg Kroah-Hartman <gregkh@suse.de>,
        linux-kernel@vger.kernel.org
In-Reply-To: <20101212192554.GA32583@bart.evergreen.loc>
References: <1292176591-26081-1-git-send-email-agimenez@sysvalve.es>
	 <1292176591-26081-4-git-send-email-agimenez@sysvalve.es>
	 <1292180668.18202.43.camel@Joe-Laptop>
	 <20101212192554.GA32583@bart.evergreen.loc>
Content-Type: text/plain; charset="UTF-8"
Date: Sun, 12 Dec 2010 11:46:09 -0800
Message-ID: <1292183170.18202.56.camel@Joe-Laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 955
Lines: 21

On Sun, 2010-12-12 at 20:25 +0100, L. Alberto Giménez wrote:
> On Sun, Dec 12, 2010 at 11:04:28AM -0800, Joe Perches wrote:
> > On Sun, 2010-12-12 at 18:56 +0100, L. Alberto Giménez wrote:
> > > diff --git a/drivers/staging/rt2860/pci_main_dev.c b/drivers/staging/rt2860/pci_main_dev.c
> > > @@ -601,15 +600,15 @@ void hex_dump(char *str, unsigned char *pSrcBufVA, unsigned int SrcBufLen)
> > >[...]
> > This should use print_hex_dump
> Ok, but I'll have to figure out how to translate the arguments without losing
> the original developers intended format.

I think you can change the format without concern.

print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 1,
	       pSrcBufVA, SrcBufLen, true);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/