Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756122Ab0LLXsi (ORCPT ); Sun, 12 Dec 2010 18:48:38 -0500 Received: from one.firstfloor.org ([213.235.205.2]:36865 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756110Ab0LLXsf (ORCPT ); Sun, 12 Dec 2010 18:48:35 -0500 From: Andi Kleen References: <201012131244.547034648@firstfloor.org> In-Reply-To: <201012131244.547034648@firstfloor.org> To: socketcan@hartkopp.net, ak@linux.intel.com, torvalds@linux-foundation.org, davem@davemloft.net, gregkh@suse.de, linux-kernel@vger.kernel.org, stable@kernel.org Subject: [PATCH] [207/223] can-bcm: fix minor heap overflow Message-Id: <20101212234834.4BEDEB27BF@basil.firstfloor.org> Date: Mon, 13 Dec 2010 00:48:34 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1521 Lines: 41 2.6.35-longterm review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Hartkopp commit 0597d1b99fcfc2c0eada09a698f85ed413d4ba84 upstream. On 64-bit platforms the ASCII representation of a pointer may be up to 17 bytes long. This patch increases the length of the buffer accordingly. http://marc.info/?l=linux-netdev&m=128872251418192&w=2 Reported-by: Dan Rosenberg Signed-off-by: Oliver Hartkopp Signed-off-by: Andi Kleen CC: Linus Torvalds Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/can/bcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/net/can/bcm.c =================================================================== --- linux.orig/net/can/bcm.c +++ linux/net/can/bcm.c @@ -125,7 +125,7 @@ struct bcm_sock { struct list_head tx_ops; unsigned long dropped_usr_msgs; struct proc_dir_entry *bcm_proc_read; - char procname [9]; /* pointer printed in ASCII with \0 */ + char procname [20]; /* pointer printed in ASCII with \0 */ }; static inline struct bcm_sock *bcm_sk(const struct sock *sk) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/