Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755994Ab0LLXzl (ORCPT ); Sun, 12 Dec 2010 18:55:41 -0500 Received: from one.firstfloor.org ([213.235.205.2]:36729 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755937Ab0LLXsQ (ORCPT ); Sun, 12 Dec 2010 18:48:16 -0500 From: Andi Kleen References: <201012131244.547034648@firstfloor.org> In-Reply-To: <201012131244.547034648@firstfloor.org> To: gregkh@suse.de, ak@linux.intel.com, linux-kernel@vger.kernel.org, stable@kernel.org Subject: [PATCH] [189/223] Staging: samsung-laptop: fix up my fixup for some sysfs attribute permissions Message-Id: <20101212234815.05A4AB27BF@basil.firstfloor.org> Date: Mon, 13 Dec 2010 00:48:14 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1266 Lines: 36 2.6.35-longterm review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 4d7bc388b44e42a1feafa35e50eef4f24d6ca59d upstream. They should be writable by root, not readable. Doh, stupid me with the wrong flags. Reported-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman Signed-off-by: Andi Kleen --- drivers/staging/samsung-laptop/samsung-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/staging/samsung-laptop/samsung-laptop.c =================================================================== --- linux.orig/drivers/staging/samsung-laptop/samsung-laptop.c +++ linux/drivers/staging/samsung-laptop/samsung-laptop.c @@ -356,7 +356,7 @@ static ssize_t set_silent_state(struct d } return count; } -static DEVICE_ATTR(silent, S_IRUSR | S_IRUGO, +static DEVICE_ATTR(silent, S_IWUSR | S_IRUGO, get_silent_state, set_silent_state); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/