Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398Ab0LMF5y (ORCPT ); Mon, 13 Dec 2010 00:57:54 -0500 Received: from mail-ww0-f66.google.com ([74.125.82.66]:48422 "EHLO mail-ww0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078Ab0LMF5x (ORCPT ); Mon, 13 Dec 2010 00:57:53 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; b=WGsNkrIQglFIZs8O1J1Ur2YOaDTDQs8Ps+7dulY4tozSV/kQr8Ap650jhX8QXMNdY+ odOD5c1Nar4KcIv7kioB0FMpZO2hizUHN63Y+ui7GdosqJi3VQRspfj1Y9++P1tbgoF5 qZscagmadhAqS1glK1Yz6rwS4d6blLViKer8Q= Date: Mon, 13 Dec 2010 08:56:37 +0300 From: Dan Carpenter To: Joe Perches Cc: =?iso-8859-1?Q?L=2E_Alberto_Gim=E9nez?= , devel@linuxdriverproject.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Staging: rt2860: include KERN_* in printk Message-ID: <20101213055637.GA1620@bicker> Mail-Followup-To: Dan Carpenter , Joe Perches , =?iso-8859-1?Q?L=2E_Alberto_Gim=E9nez?= , devel@linuxdriverproject.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org References: <1292176591-26081-1-git-send-email-agimenez@sysvalve.es> <1292176591-26081-4-git-send-email-agimenez@sysvalve.es> <1292180668.18202.43.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1292180668.18202.43.camel@Joe-Laptop> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 43 On Sun, Dec 12, 2010 at 11:04:28AM -0800, Joe Perches wrote: > On Sun, 2010-12-12 at 18:56 +0100, L. Alberto Gim?nez wrote: > > Fix checkpatch complains > > diff --git a/drivers/staging/rt2860/common/ee_efuse.c b/drivers/staging/rt2860/common/ee_efuse.c > [] > > @@ -281,8 +281,8 @@ int set_eFusedump_Proc(struct rt_rtmp_adapter *pAd, char *arg) > > > > eFuseReadPhysical(pAd, &InBuf[0], 4, &InBuf[2], 2); > > if (i % 4 == 0) > > - printk("\nBlock %x:", i / 8); > > - printk("%04x ", InBuf[2]); > > + printk(KERN_DEBUG "\nBlock %x:", i / 8); > > + printk(KERN_DEBUG "%04x ", InBuf[2]); > > } > > return TRUE; > > } > > Not quite. Use: > > (before the for) > printk(KERN_DEBUG "Block 0: "); > > for(...) > [] > if (i && i % 4 == 0) { > printk(KERN_CONT "\n"); > printk(KERN_DEBUG "Block %x: ", i / 8); > } > printk(KERN_CONT " %04x", InBuf[2]); > } > printk(KERN_CONT "\n"); > This is dead code anyway. Just remove the whole set_eFusedump_Proc() function. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/