Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504Ab0LMGDk (ORCPT ); Mon, 13 Dec 2010 01:03:40 -0500 Received: from mail.perches.com ([173.55.12.10]:2547 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119Ab0LMGDk (ORCPT ); Mon, 13 Dec 2010 01:03:40 -0500 Subject: Re: [PATCH 3/3] Staging: rt2860: include KERN_* in printk From: Joe Perches To: Dan Carpenter Cc: "L. Alberto" =?ISO-8859-1?Q?Gim=E9nez?= , devel@linuxdriverproject.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org In-Reply-To: <20101213055637.GA1620@bicker> References: <1292176591-26081-1-git-send-email-agimenez@sysvalve.es> <1292176591-26081-4-git-send-email-agimenez@sysvalve.es> <1292180668.18202.43.camel@Joe-Laptop> <20101213055637.GA1620@bicker> Content-Type: text/plain; charset="UTF-8" Date: Sun, 12 Dec 2010 22:03:37 -0800 Message-ID: <1292220217.26970.2.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 26 On Mon, 2010-12-13 at 08:56 +0300, Dan Carpenter wrote: > On Sun, Dec 12, 2010 at 11:04:28AM -0800, Joe Perches wrote: > > On Sun, 2010-12-12 at 18:56 +0100, L. Alberto Giménez wrote: > > for(...) > > [] > > if (i && i % 4 == 0) { > > printk(KERN_CONT "\n"); > > printk(KERN_DEBUG "Block %x: ", i / 8); > > } > > printk(KERN_CONT " %04x", InBuf[2]); > > } > > printk(KERN_CONT "\n"); > This is dead code anyway. Just remove the whole set_eFusedump_Proc() > function. That was just to be instructive. I think the entire staging rt2860 is dead code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/