From: Jeremy Kerr <jeremy.kerr@canonical.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 2/2] clk: Generic support for fixed-rate clocks
Date: Mon, 13 Dec 2010 20:35:37 +0800
User-Agent: KMail/1.13.5 (Linux/2.6.35-23-generic; KDE/4.5.1; x86_64; ; )
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <1291774094.269634.503532219345.0.gpush@pororo> <1291774094.270492.31002734529.2.gpush@pororo> <20101213121413.GA29833@pengutronix.de>
In-Reply-To: <20101213121413.GA29833@pengutronix.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201012132035.41371.jeremy.kerr@canonical.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1413
Lines: 46

Hi Sascha,

> > +extern struct clk_ops clk_fixed_ops;
> > +
> > +#define INIT_CLK_FIXED(name, r) { \
> > +	.clk = INIT_CLK(name.clk, clk_fixed_ops), \
> > +	.rate = (r) \
> > +}
> 
> Is there any other valid usecase for this other than
> 
> struct clk_fixed bla = INIT_CLK_FIXED(bla, rate);
> 
> Otherwise I suggest to convert the macro to:
> 
> #define INIT_CLK_FIXED(name, r) \
> 	struct clk_fixed name = { \
> 		.clk = INIT_CLK(name.clk, clk_fixed_ops), \
> 		.rate = (r) \
> 	}
> 
> This way we do not have to specify the same name twice (and it has
> to be exactly the same name, otherwise it won't compile).

For the system-wide INIT_CLK* macros, I've intentionally made them initalisers 
rather than declarators, so that we can use them in other declarators (ie, the 
usage of INIT_CLK() above). This would be relevant if someone is using 
clk_fixed in their struct - probably not likely, but good to be consistent.

But yes, it would be good to avoid having to specify the name twice - how 
about adding a:

#define DEFINE_CLK_FIXED(name, r) \
	struct clk_fixed name = INIT_CLK_FIXED(name, r)

- just like DEFINE_MUTEX and MUTEX_INITIALIZER.

Cheers,


Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/