Date: Mon, 13 Dec 2010 18:27:09 +0530
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Dan Carpenter <error27@gmail.com>, jeffm@suse.com,
        linux-kernel@vger.kernel.org, brian@xyzw.org
Subject: Re: delayacct: alignment changes break iotop
Message-ID: <20101213125709.GB14178@balbir.in.ibm.com>
Reply-To: balbir@linux.vnet.ibm.com
References: <20101213113745.GE1620@bicker>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20101213113745.GE1620@bicker>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1115
Lines: 30

* Dan Carpenter <error27@gmail.com> [2010-12-13 14:37:45]:

> Iotop uses hardcoded offsets to find the taskstats struct members.
> This got changed in 2.6.37 so it now iotop doesn't work on amd64.  The
> offending commit is:
> 
> commit 85893120699f8bae8caa12a8ee18ab5fceac978e
> Author: Jeff Mahoney <jeffm@suse.com>
> Date:   Wed Oct 27 15:34:43 2010 -0700
> 
>     delayacct: align to 8 byte boundary on 64-bit systems
> 
> Brian Rogers gets the reported-by tag.  The bugzilla entry is:
> https://bugzilla.kernel.org/show_bug.cgi?id=24272
>

Thanks for the report, looks like the change did not even bump the
version field. Sorry, its my fault, I should have caught it earlier.
iotop hard coding member offsets is not bad as long as we don't break
ABI (expected from us). Any chance you could dump the offsets before
and after the change?

-- 
	Three Cheers,
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/