Date: Mon, 13 Dec 2010 16:04:50 +0100
From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "J. Bruce Fields" <bfields@fieldses.org>, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] fs/splice: Pull buf->ops->confirm() from
	splice_from_pipe actors
Message-ID: <20101213150450.GA12865@rere.qmqm.pl>
References: <17eaa416d82b1c57f70443e56ad22feb3c3a3a6f.1292184347.git.mirq-linux@rere.qmqm.pl> <4D0621CB.2010809@fusionio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4D0621CB.2010809@fusionio.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 924
Lines: 20

On Mon, Dec 13, 2010 at 02:38:19PM +0100, Jens Axboe wrote:
> On 2010-12-12 22:23, Micha? Miros?aw wrote:
> > This patch pulls calls to buf->ops->confirm() from all actors passed
> > (also indirectly) to splice_from_pipe_feed().
> Why? The point of ->confirm() is to ensure that the contents are
> stable, otherwise the pages in the pipe could merely be in flight.
> It's needed if you need to actually look at the data, rather than just
> reference it.

I should have put this more clearly in the patch description:
the ->confirm() call is moved to splice_from_pipe_feed(), so that every
actor has its data guaranteed to be stable before it runs.

Best Regards,
Micha? Miros?aw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/