Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753589Ab0LMT2A (ORCPT ); Mon, 13 Dec 2010 14:28:00 -0500 Received: from mtagate3.uk.ibm.com ([194.196.100.163]:34609 "EHLO mtagate3.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757Ab0LMT17 (ORCPT ); Mon, 13 Dec 2010 14:27:59 -0500 Date: Mon, 13 Dec 2010 20:27:45 +0100 (CET) From: Sebastian Ott X-X-Sender: sebott@localhost6.localdomain6 To: Greg KH cc: Kay Sievers , linux-kernel@vger.kernel.org Subject: Re: [RFC] bind/unbind uevent In-Reply-To: <20101208160255.GB10313@suse.de> Message-ID: References: <20101207162755.GA32328@suse.de> <20101207183305.GA21802@suse.de> <20101208160255.GB10313@suse.de> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) Organization: "IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294" MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1889 Lines: 48 On Wed, 8 Dec 2010, Greg KH wrote: > On Wed, Dec 08, 2010 at 11:18:27AM +0100, Sebastian Ott wrote: > > On Tue, 7 Dec 2010, Kay Sievers wrote: > > > On Tue, Dec 7, 2010 at 19:33, Greg KH wrote: > > > > On Tue, Dec 07, 2010 at 06:29:37PM +0100, Sebastian Ott wrote: > > > > > > >> So I'm searching for a trigger when these attributes are created, or > > > >> in other words when the device is useable, which I think translates to > > > >> when a driver is bound to this device. > > > > > > > > Again, KOBJ_ADD is the correct one. > > > > > > > > If your driver is creating sysfs attributes on its own, that's a bug and > > > > should be fixed. > > > > > > Sounds a bit like the driver should create its own child device with > > > its own properties, instead of mangling around with attributes at a > > > device it binds to. > > > > Yes, I get that feeling too. But I'm talking about existing drivers > > and I don't think I can change their whole structure. > > It's just a matter of putting the attributes in a table and passing that > to the bus code the driver registers with. Only a minor change in the > driver is needed to resolve this. I don't get it. The current situation is, that our drivers add attributes to the device they are about to bind with, in the probe function. I think we agree that it would be better if those drivers would register a child device and add attributes to this one. But my concern is that this would break userspace which walks the sysfs tree and changes attributes, since it changed from: /sys/devices/$DEV/$ATTR to: /sys/devices/$DEV/$CHILD/$ATTR > > good luck, > > greg k-h > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/