Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756228Ab0LMVHt (ORCPT ); Mon, 13 Dec 2010 16:07:49 -0500 Received: from mailc.microsoft.com ([131.107.115.214]:10091 "EHLO smtp.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719Ab0LMVHs convert rfc822-to-8bit (ORCPT ); Mon, 13 Dec 2010 16:07:48 -0500 From: Hank Janssen To: Jesper Juhl CC: "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" , Haiyang Zhang , Evgeniy Polyakov , Ky Srinivasan Subject: RE: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize Thread-Topic: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize Thread-Index: AQHLmwTWTCfBOZ+WHUG7YLQqdwCl/JOfXiMA//9+/JA= Date: Mon, 13 Dec 2010 21:07:46 +0000 Message-ID: <8AFC7968D54FB448A30D8F38F259C5622C0BCB78@TK5EX14MBXC116.redmond.corp.microsoft.com> References: <1292272498-29483-1-git-send-email-hjanssen@microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.54.123.12] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 955 Lines: 30 > -----Original Message----- > From: Jesper Juhl [mailto:jj@chaosbits.net] > Sent: Monday, December 13, 2010 12:48 PM > You are leaking memory in the failure path. If for example one or two > allocations succeed but one or two fail, then you'll leak the two successful > allocations. > > I believe this should be > > if (!shut_txf_buf || !time_txf_buf || !hbeat_txf_buf) { > printk(KERN_INFO > "Unable to allocate memory for receive buffer\n"); > kfree(hbeat_txf_buf); > kfree(time_txf_buf); > kfree(shut_txf_buf); > return -ENOMEM; > ... > Oops, you are correct. Resubmitting the patch in a few minutes. Hank. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/