Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757380Ab0LNAL0 (ORCPT ); Mon, 13 Dec 2010 19:11:26 -0500 Received: from smtp.microsoft.com ([131.107.115.212]:31781 "EHLO smtp.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755113Ab0LNALZ convert rfc822-to-8bit (ORCPT ); Mon, 13 Dec 2010 19:11:25 -0500 From: Hank Janssen To: Jesper Juhl , Ky Srinivasan CC: "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" , "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , Evgeniy Polyakov , "Haiyang Zhang" Subject: RE: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize Thread-Topic: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize Thread-Index: AQHLmwTWTCfBOZ+WHUG7YLQqdwCl/JOfc7GAgAAdgwD//38vEA== Date: Tue, 14 Dec 2010 00:11:23 +0000 Message-ID: <8AFC7968D54FB448A30D8F38F259C5622C0BD022@TK5EX14MBXC116.redmond.corp.microsoft.com> References: <1292272498-29483-1-git-send-email-hjanssen@microsoft.com> <4D0636270200003000091D23@novprvoes0310.provo.novell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.54.51.78] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 33 > -----Original Message----- > From: Jesper Juhl [mailto:jj@chaosbits.net] > Sent: Monday, December 13, 2010 3:51 PM > To: Ky Srinivasan > > > + shut_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); > > > + time_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); > > > + hbeat_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); > > Why are these allocations GFP_ATOMIC. Clearly this is in module > loading context and you can afford to sleep. GFP_KERNEL should be fine. > > > > I actually also noticed this when I did my first review of the patch, > but > I didn't point it out since I thought that "there must be a good > reason". > But now that you point it out and I look at the code once more I can't > actually think of a "good reason",, so I agree with you completely that > these should just be GFP_KERNEL. I was looking at some of the back code to make sure it is okay, and I see No reason not make this change either. I will change it and resubmit. Thanks, Hank. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/