Subject: Re: [RFC -v2 PATCH 2/3] sched: add yield_to function
From: Mike Galbraith <efault@gmx.de>
To: vatsa@linux.vnet.ibm.com
Cc: Rik van Riel <riel@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Avi Kiviti <avi@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Chris Wright <chrisw@sous-sol.org>
In-Reply-To: <20101214112655.GB3665@linux.vnet.ibm.com>
References: <20101213224434.7495edb2@annuminas.surriel.com>
	 <20101213224657.7e141746@annuminas.surriel.com>
	 <1292306896.7448.157.camel@marge.simson.net>
	 <20101214102409.GA3665@linux.vnet.ibm.com>
	 <1292324638.7436.29.camel@marge.simson.net>
	 <20101214112655.GB3665@linux.vnet.ibm.com>
Content-Type: text/plain
Date: Tue, 14 Dec 2010 13:47:31 +0100
Message-Id: <1292330851.7436.98.camel@marge.simson.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2237
Lines: 48

On Tue, 2010-12-14 at 16:56 +0530, Srivatsa Vaddagiri wrote:
> On Tue, Dec 14, 2010 at 12:03:58PM +0100, Mike Galbraith wrote:
> > On Tue, 2010-12-14 at 15:54 +0530, Srivatsa Vaddagiri wrote:
> > > On Tue, Dec 14, 2010 at 07:08:16AM +0100, Mike Galbraith wrote:
> > 
> > > > That part looks ok, except for the yield cross cpu bit.  Trying to yield
> > > > a resource you don't have doesn't make much sense to me.
> > > 
> > > So another (crazy) idea is to move the "yieldee" task on another cpu over to 
> > > yielding task's cpu, let it run till the end of yielding tasks slice and then
> > > let it go back to the original cpu at the same vruntime position!
> > 
> > Yeah, pulling the intended recipient makes fine sense.  If he doesn't
> > preempt you, you can try to swap vruntimes or whatever makes arithmetic
> > sense and will help.  Dunno how you tell him how long he can keep the
> > cpu though,
> 
> can't we adjust the new task's [prev_]sum_exec_runtime a bit so that it is 
> preempted at the end of yielding task's timeslice?

And dork up accounting.  Why?  Besides, it won't work because you have
no idea who may preempt whom, when, and for how long.

(Why do people keep talking about timeslice?  The only thing that exists
is lag that changes the instant anyone does anything of interest.)

> > and him somehow going back home needs to be a plain old
> > migration, no fancy restoration of ancient history vruntime.
> 
> What is the issue if it gets queued at the old vruntime (assuming fair stick is
> still behind that)? Without that it will hurt fairness for the yieldee (and
> perhaps of the overall VM in this case).

Who all are you placing this task in front of or behind based upon a
non-existent relationship?

Your recipient may well have been preempted, and is now further behind
than the completely irrelevant to the current situation stored vruntime
would indicate, so why would you want to move it rightward?  Certainly
not in the interest of fairness.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/