Date: Tue, 14 Dec 2010 20:29:20 +0530
From: "Suzuki K. Poulose" <suzuki@in.ibm.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org,
        Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
        Christoph Hellwig <hch@lst.de>, Masami Hiramatsu <mhiramat@redhat.com>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>,
        Andi Kleen <andi@firstfloor.org>, Roland McGrath <roland@redhat.com>,
        Amerigo Wang <amwang@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC] [Patch 0/21] Non disruptive application core dump
 infrastructure
Message-ID: <20101214202920.6835a3c2@suzukikp>
In-Reply-To: <20101214105405.GB4834@core2.telecom.by>
References: <20101214152259.67896960@suzukikp>
	<20101214105405.GB4834@core2.telecom.by>
Organization: IBM
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 25

On Tue, 14 Dec 2010 12:54:05 +0200
Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Tue, Dec 14, 2010 at 03:22:59PM +0530, Suzuki K. Poulose wrote:
> > The interface is provided by a /proc/pid/core file, reading which can give the 
> 
> What happens when process opens /proc/self/core ?
The current thread will be skipped for freeze(), and all the others will be 
frozen.We fill in the register states with 0's for the active threads.

> What happens when process opens /proc/self/core and coredumps before close(2).

Thanks for pointing this out. With the current code, this causes a hang for the
 current process, waiting for the other threads to clear. I will think about 
a solution to this making use of the mm->core_state information.


Thanks a lot for the review.

Suzuki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/