Date: Tue, 14 Dec 2010 16:57:08 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: "Suzuki K. Poulose" <suzuki@in.ibm.com>
Cc: linux-kernel@vger.kernel.org,
        Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
        Christoph Hellwig <hch@lst.de>, Masami Hiramatsu <mhiramat@redhat.com>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>,
        Andi Kleen <andi@firstfloor.org>, Roland McGrath <roland@redhat.com>,
        Amerigo Wang <amwang@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Patch 5/21] Rename compat versions of the reusable core
	generation routines
Message-ID: <20101214155708.GC11400@redhat.com>
References: <20101214152259.67896960@suzukikp> <20101214153314.04d05dd2@suzukikp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101214153314.04d05dd2@suzukikp>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1425
Lines: 38

On 12/14, Suzuki K. Poulose wrote:
>
> Rename the ELF class specific functions reusable for the application core dump 
> infrastructure. The compat ELF class routines are prepended with compat_ .
>
> Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com>
> ---
>  fs/compat_binfmt_elf.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> Index: linux-2.6.36-rc7/fs/compat_binfmt_elf.c
> ===================================================================
> --- linux-2.6.36-rc7.orig/fs/compat_binfmt_elf.c
> +++ linux-2.6.36-rc7/fs/compat_binfmt_elf.c
> @@ -127,6 +127,13 @@ static void cputime_to_compat_timeval(co
>  #define init_elf_binfmt		init_compat_elf_binfmt
>  #define exit_elf_binfmt		exit_compat_elf_binfmt
>
> +/* Rename the functions that may be reused */
> +#define fill_elf_header 	compat_fill_elf_header
> +#define fill_psinfo		compat_fill_psinfo
> +#define fill_prstatus		compat_fill_prstatus
> +#define fill_extnum_info	compat_fill_extnum_info
> +#define fill_auxv_note		compat_fill_auxv_note

Can't undestand.... Afaics, the kernel can't be compiled
with this change until the next patches actually implement
compat_xxx ?

This is not bisect friendly.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/