Date: Tue, 14 Dec 2010 21:47:21 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jan Kiszka <jan.kiszka@web.de>
cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
        linux-kernel@vger.kernel.org, kvm <kvm@vger.kernel.org>,
        Tom Lyon <pugs@cisco.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v3 1/4] genirq: Introduce driver-readable IRQ status
 word
In-Reply-To: <3575edb77b3e824f921b6fdbbe5a4fdb8a549e17.1292281184.git.jan.kiszka@web.de>
Message-ID: <alpine.LFD.2.00.1012142145480.12146@localhost6.localdomain6>
References: <cover.1292281184.git.jan.kiszka@web.de> <3575edb77b3e824f921b6fdbbe5a4fdb8a549e17.1292281184.git.jan.kiszka@web.de>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 27

On Mon, 13 Dec 2010, Jan Kiszka wrote:
> +/**
> + *	get_irq_status - read interrupt line status word
> + *	@irq: Interrupt line of the status word
> + *
> + *	This returns the current content of the status word associated with
> + *	the given interrupt line. See IRQS_* flags for details.
> + */
> +unsigned long get_irq_status(unsigned int irq)
> +{
> +	struct irq_desc *desc = irq_to_desc(irq);
> +
> +	return desc ? desc->irq_data.drv_status : 0;
> +}
> +EXPORT_SYMBOL_GPL(get_irq_status);

We should document that this is a snapshot and in no way serialized
against modifications of drv_status. I'll fix up the kernel doc.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/