Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758078Ab0LNVsz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Dec 2010 16:48:55 -0500
Received: from ifup.org ([198.145.64.140]:48076 "EHLO ifup.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755107Ab0LNVsx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Dec 2010 16:48:53 -0500
Date: Tue, 14 Dec 2010 13:48:05 -0800
From: Brandon Philips <brandon@ifup.org>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: Dave Young <hidave.darkstar@gmail.com>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@infradead.org>,
        Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
        Chris Clayton <chris2553@googlemail.com>
Subject: Re: [PATCH] bttv: fix mutex use before init
Message-ID: <20101214214805.GD5900@hanuman.home.ifup.org>
References: <20101212131550.GA2608@darkstar>
 <AANLkTinaNjPjNbxE+OyRsY_jJxDW-pwehTPgyAWzqfzd@mail.gmail.com>
 <20101214003024.GA3575@hanuman.home.ifup.org>
 <AANLkTi=ic4i+whV7-gtA7jvWJkPE+bizLdra6OMDf6Cp@mail.gmail.com>
 <AANLkTimZ=cdu--GsVWotAir-2QpuXQQBg+7UtkVvKzO=@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AANLkTimZ=cdu--GsVWotAir-2QpuXQQBg+7UtkVvKzO=@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2183
Lines: 46

On 22:13 Tue 14 Dec 2010, Torsten Kaiser wrote:
> On Tue, Dec 14, 2010 at 9:56 PM, Torsten Kaiser
> <just.for.lkml@googlemail.com> wrote:
> > Using the card also still works, but I think I found out what was
> > causing sporadic shutdown problems with 37-rc kernels: When I try to
> > exit tvtime it gets stuck in an uninterruptible D state and can't be
> > killed. And that seems to mess up the shutdown.
> >
> > But this happens independent with or without your patch and looks like
> > different problem.
> >
> > SysRQ+W provided this stack trace, maybe someone seens an obvious bug...:
> > [ ?274.772528] ?ffff8800dec69680 0000000000000086 ffffffff81089d73
> > ffff8800729d05a0
> > [ ?274.778599] ?0000000000011480 ffff8800df923fd8 0000000000011480
> > ffff8800df922000
> > [ ?274.778599] ?ffff8800df923fd8 0000000000011480 ffff8800dec69680
> > 0000000000011480
> > [ ?274.778599] Call Trace:
> > [ ?274.778599] ?[<ffffffff81089d73>] ? free_pcppages_bulk+0x343/0x3b0
> > [ ?274.778599] ?[<ffffffff8156d0e1>] ? __mutex_lock_slowpath+0xe1/0x160
> > [ ?274.778599] ?[<ffffffff8156cd8a>] ? mutex_lock+0x1a/0x40
> > [ ?274.778599] ?[<ffffffff8141ab7f>] ? free_btres_lock.clone.19+0x3f/0x100
> > [ ?274.778599] ?[<ffffffff8141d311>] ? bttv_release+0x1c1/0x1e0
> > [ ?274.778599] ?[<ffffffff813fe4ba>] ? v4l2_release+0x4a/0x70
> > [ ?274.778599] ?[<ffffffff810c5291>] ? fput+0xe1/0x250
> > [ ?274.778599] ?[<ffffffff810c1d59>] ? filp_close+0x59/0x80
> > [ ?274.778599] ?[<ffffffff810c1e0b>] ? sys_close+0x8b/0xe0
> > [ ?274.778599] ?[<ffffffff8100253b>] ? system_call_fastpath+0x16/0x1b
> 
> The calls to lock btv->lock in bttv_release() where added as part of
> the BKL removal, but I do not understand enough to fix this.
> Can this be dropped from bttv_release() completely, or would an
> unlocked version of free_btres_lock() be better?

I would create an unlocked version of free_btres_lock. Does that fix the
issue?

Cheers,

	Brandon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/