Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932420Ab0LNWvg (ORCPT ); Tue, 14 Dec 2010 17:51:36 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:42236 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760167Ab0LNWvf (ORCPT ); Tue, 14 Dec 2010 17:51:35 -0500 Date: Tue, 14 Dec 2010 22:51:26 +0000 From: Russell King - ARM Linux To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Cc: linux-kernel@vger.kernel.org, Nicolas Pitre , Catalin Marinas , Will Deacon , Kevin Hilman , Tony Lindgren , Jeremy Kerr , Eric Miao , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arch/arm/kernel: use cpu_relax() in halt loops Message-ID: <20101214225126.GD24303@n2100.arm.linux.org.uk> References: <20101214224848.GA1706@debian.debian> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20101214224848.GA1706@debian.debian> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 18 On Tue, Dec 14, 2010 at 11:48:48PM +0100, Jonathan Neusch?fer wrote: > Looking throught arch/arm/kernel/ I found some halt loops. > I just thought we could save some power here using cpu_relax(), > or am I missing something? #if __LINUX_ARM_ARCH__ == 6 #define cpu_relax() smp_mb() #else #define cpu_relax() barrier() #endif IOW, it's either a memory barrier or compiler barrier on ARM; it doesn't do any power saving. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/