Date: Wed, 15 Dec 2010 07:52:35 +0530
From: "Suzuki K. Poulose" <suzuki@in.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
        Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
        Christoph Hellwig <hch@lst.de>, Masami Hiramatsu <mhiramat@redhat.com>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>,
        Andi Kleen <andi@firstfloor.org>, Roland McGrath <roland@redhat.com>,
        Amerigo Wang <amwang@redhat.com>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Patch 4/21] Make fill_psinfo generic
Message-ID: <20101215075235.5e3f36b1@suzukikp>
In-Reply-To: <AANLkTimA635P-X5SVaBwY9exfODSgzhDWCJebSRcbLO=@mail.gmail.com>
References: <20101214152259.67896960@suzukikp>
	<20101214153135.5f4423e0@suzukikp>
	<AANLkTimA635P-X5SVaBwY9exfODSgzhDWCJebSRcbLO=@mail.gmail.com>
Organization: IBM
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 29

On Tue, 14 Dec 2010 07:55:00 -0800
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Tue, Dec 14, 2010 at 2:01 AM, Suzuki K. Poulose <suzuki@in.ibm.com> wrote:
> > + ? ? ? /*
> > + ? ? ? ?* If we are dumping core for "another task"
> > + ? ? ? ?* we can't use copy_from_user().
> > + ? ? ? ?*/
> > + ? ? ? if (p->group_leader == current->group_leader) {
> 
> This is totally bogus. "group_leader" has absolutely nothing to do
> with whether the process shares the address space. It's about signal
> sharing etc.
> 
> The way to check whether they share the same address space is to check
> whether "mm" is the same.
> 

OK. I will make use of the mm here.

Thanks
Suzuki


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/