Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754241Ab0LOH5v (ORCPT ); Wed, 15 Dec 2010 02:57:51 -0500 Received: from jacques.telenet-ops.be ([195.130.132.50]:49684 "EHLO jacques.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753184Ab0LOH5u (ORCPT ); Wed, 15 Dec 2010 02:57:50 -0500 Message-ID: <4D0874FB.8080503@telenet.be> Date: Wed, 15 Dec 2010 08:57:47 +0100 From: Jef Driesen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Robert Lukassen CC: Greg KH , David Brownell , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: g_serial: Allow to override the default VID/PID References: <4CE6F807.1090607@telenet.be> <1290209554-7026-1-git-send-email-jefdriesen@telenet.be> <20101120001247.GB17421@kroah.com> <4CE853BF.80504@telenet.be> <20101130174605.GC19977@kroah.com> <4CF96A9D.8070800@telenet.be> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 14 On 06/12/10 09:09, Robert Lukassen wrote: > Yes, providing access to those module parameters was the original goal. I > agree that my patch should be reverted and I'll try to come up with a method > of accessing these values without violating the information hiding principles > too much. I don't like accessing globals. Do I have to take any action to make sure the original commit [1] gets reverted? [1] 1ab83238740ff1e1773d5c13ecac43c60cf4aec4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/