Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907Ab0LONoF (ORCPT ); Wed, 15 Dec 2010 08:44:05 -0500 Received: from mail.atmel.fr ([81.80.104.162]:44584 "EHLO atmel-es2.atmel.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753653Ab0LONoD (ORCPT ); Wed, 15 Dec 2010 08:44:03 -0500 Message-ID: <4D08C61B.8010006@atmel.com> Date: Wed, 15 Dec 2010 14:43:55 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Sergei Shtylyov CC: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] MTD: m25p80: add debugging trace in sst_write() References: <1292414372-17085-1-git-send-email-nicolas.ferre@atmel.com> <4D08C1C8.3090100@ru.mvista.com> In-Reply-To: <4D08C1C8.3090100@ru.mvista.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 44 Le 15/12/2010 14:25, Sergei Shtylyov : > Hello. > > On 15-12-2010 14:59, Nicolas Ferre wrote: > >> Add a DEBUG(MTD_DEBUG_LEVEL2, ..) trace at beginning of sst_write() >> function as >> it is done in m25p80_write() function. > >> Signed-off-by: Nicolas Ferre > [...] > >> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c >> index bf5a002..e6b5707 100644 >> --- a/drivers/mtd/devices/m25p80.c >> +++ b/drivers/mtd/devices/m25p80.c >> @@ -482,6 +482,10 @@ static int sst_write(struct mtd_info *mtd, loff_t >> to, size_t len, >> size_t actual; >> int cmd_sz, ret; >> >> + DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n", >> + dev_name(&flash->spi->dev), __func__, "to", > > What's the point of printing "to" as variable? :-) Good question... Maybe a way to have the same shape of messages... In my patch it is for sure to comply with this driver way of dealing with DEBUG messages. It is "to" in this function like its sister m25p80_write(). But it is also "from" or "at" in others... >> + (u32)to, len); >> + Cheers, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/