Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286Ab0LOOMw (ORCPT ); Wed, 15 Dec 2010 09:12:52 -0500 Received: from mail-ey0-f171.google.com ([209.85.215.171]:55249 "EHLO mail-ey0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753691Ab0LOOMv convert rfc822-to-8bit (ORCPT ); Wed, 15 Dec 2010 09:12:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=qVmxuVMptr+Hvy4o+y6ttoDgCTKnEZ7aZGqp7QPEYoktbHgLi83c6zjJHNaFX9N9rg /I3Pkfu4zavgPIq0BM/drUJ6xmreVwLpS0VWr9jV/+s602d4Hhs8BVEOC+rwM4fK812u EuN7pSzzRRPk7VBcWvJXyYRYJSIf+y4qtSwSs= MIME-Version: 1.0 In-Reply-To: <201012142058.04469.rjw@sisk.pl> References: <201012130128.31243.rjw@sisk.pl> <201012142058.04469.rjw@sisk.pl> Date: Wed, 15 Dec 2010 22:12:49 +0800 Message-ID: Subject: Re: [RFC][PATCH 2/4] PM: Remove redundant checks from core device resume routines From: Ming Lei To: "Rafael J. Wysocki" Cc: Linus Torvalds , Alan Stern , LKML , Linux-pm mailing list Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 22 2010/12/15 Rafael J. Wysocki : > On Tuesday, December 14, 2010, Ming Lei wrote: >> Seems it may apply in other cases(dpm_prepare/dpm_suspend >> /dpm_suspend_noirq) too? > > I thought about that, but in these cases the status is changed after the > callback has returned and only if it's succeeded. ?Moreover, if the callback > hasn't been successful, the device is not moved to the new list, so I think > it's better to leave that as is. Yes, you are right, sorry for my noise, :-( thanks, -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/