Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754152Ab0LOSHm (ORCPT ); Wed, 15 Dec 2010 13:07:42 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:58439 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab0LOSHj (ORCPT ); Wed, 15 Dec 2010 13:07:39 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6198"; a="66745128" Message-ID: <4D0903EB.6080206@codeaurora.org> Date: Wed, 15 Dec 2010 10:07:39 -0800 From: Steve Muckle User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20101019 Lightning/1.0b3pre Thunderbird/3.1.4 MIME-Version: 1.0 To: Daniel Walker CC: David Brown , Sergei Shtylyov , Stepan Moskovchenko , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/7] msm: Physical offset for MSM8960 References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1292384961-8851-3-git-send-email-stepanm@codeaurora.org> <4D08BFFC.3020103@ru.mvista.com> <20101215135508.GB8682@huya.qualcomm.com> <1292424054.13887.5.camel@m0nster> <20101215153837.GB15817@huya.qualcomm.com> <1292435728.7789.8.camel@c-dwalke-linux.qualcomm.com> In-Reply-To: <1292435728.7789.8.camel@c-dwalke-linux.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 35 On 12/15/10 09:55, Daniel Walker wrote: > The board file is very similar, plus the ifdefs. The code differences > are the io and irq's .. The naming issue and the duplication can be 8x60 and 8960 are expected to diverge over time. It is not worth it to try and make them common in this early stage where they are the same simply because a very small amount of 8960 (and 8660 for that matter) has been sent upstream. > simplified just by combining 8960 and 8660 .. If you create two new > Kconfig options, > > config MACH_MSM8660 > bool > config MACH_MSM8960 > bool We currently use ARCH_MSM* for SoCs, and MACH_* for boards based on those SoCs. For this reason I think this scheme will be confusing and lead to machine_is_() calls everywhere. I suggest we rename 8x60 to 8660 (SteveMo's idea actually) if the current naming is largely considered unacceptable. thanks, Steve -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/