Date: Wed, 15 Dec 2010 20:40:53 +0100
Message-ID: <s5hipyuakoq.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Chris Ball <cjb@laptop.org>
Cc: Philip Rakity <prakity@marvell.com>, Aries Lee <arieslee@jmicron.com>,
        zhangfei gao <zhangfei.gao@gmail.com>, wuqm@marvell.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: Enable bus-width tests on SDHCI host
In-Reply-To: <s5h7hfbnpjs.wl%tiwai@suse.de>
References: <s5hfwtzbj8v.wl%tiwai@suse.de>
	<s5h7hfbnpjs.wl%tiwai@suse.de>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1561
Lines: 53

At Wed, 15 Dec 2010 14:17:27 +0100,
Takashi Iwai wrote:
> 
> Let's enable the new bus-width tests on SDHCI hosts unless 1-bit data
> is set forcibly.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Please drop this patch.

After a short discussion with Philip, we concluded that it's safer to
enable in individual platform side.

I'll send a patch for enabling the feature for JMicron chips later again.


thanks,

Takashi

> ---
> 
> This is a patch to be applied after
>   "mmc: Test bus-width for old MMC devices (v2)"
> 
> 
>  drivers/mmc/host/sdhci.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 0502738..51f5209 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1888,8 +1888,10 @@ int sdhci_add_host(struct sdhci_host *host)
>  	 * their platform code before calling sdhci_add_host(), and we
>  	 * won't assume 8-bit width for hosts without that CAP.
>  	 */
> -	if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
> +	if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA)) {
>  		mmc->caps |= MMC_CAP_4_BIT_DATA;
> +		mmc->caps |= MMC_CAP_BUS_WIDTH_TEST;
> +	}
>  
>  	if (caps & SDHCI_CAN_DO_HISPD)
>  		mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
> -- 
> 1.7.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/