Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755506Ab0LOUy5 (ORCPT ); Wed, 15 Dec 2010 15:54:57 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:25445 "EHLO ironport2-out.pppoe.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755424Ab0LOUyT (ORCPT ); Wed, 15 Dec 2010 15:54:19 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AisJACS3CE3O+J1F/2dsb2JhbACjEoEddMN2hUoEhGSOCQ X-IronPort-AV: E=Sophos;i="4.59,351,1288584000"; d="scan'208";a="85563558" From: matthew@wil.cx To: Greg KH Cc: linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Matthew Wilcox Subject: [PATCH 1/5] uas: Fix up the Sense IU Date: Wed, 15 Dec 2010 15:44:02 -0500 Message-Id: <1292445846-12101-1-git-send-email-matthew@wil.cx> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <20101215204147.GA1263@parisc-linux.org> References: <20101215204147.GA1263@parisc-linux.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1226 Lines: 43 From: Matthew Wilcox Add a comment to the Sense IU data structure that it's also used for Read Ready and Write Ready. Remove the 'service response' element since it's gone from the current draft (04). Signed-off-by: Matthew Wilcox --- drivers/usb/storage/uas.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 339fac3..ca277c2 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -49,14 +49,17 @@ struct command_iu { __u8 cdb[16]; /* XXX: Overflow-checking tools may misunderstand */ }; +/* + * Also used for the Read Ready and Write Ready IUs since they have the + * same first four bytes + */ struct sense_iu { __u8 iu_id; __u8 rsvd1; __be16 tag; __be16 status_qual; __u8 status; - __u8 service_response; - __u8 rsvd8[6]; + __u8 rsvd7[7]; __be16 len; __u8 sense[SCSI_SENSE_BUFFERSIZE]; }; -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/