Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579Ab0LPAai (ORCPT ); Wed, 15 Dec 2010 19:30:38 -0500 Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:19549 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672Ab0LPAag (ORCPT ); Wed, 15 Dec 2010 19:30:36 -0500 Date: Wed, 15 Dec 2010 16:30:36 -0800 From: Dmitry Torokhov To: Alexey Dobriyan Cc: LKML , Rusty Russell Subject: Re: [PATCH] Show version information for built-in modules in sysfs Message-ID: <20101216003036.GA17878@dtor-ws.eng.vmware.com> References: <20101215220019.GA6560@dtor-ws.eng.vmware.com> <20101215221454.GB6560@dtor-ws.eng.vmware.com> <20101215235312.GA15328@dtor-ws.eng.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101215235312.GA15328@dtor-ws.eng.vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1876 Lines: 41 On Wed, Dec 15, 2010 at 03:53:12PM -0800, Dmitry Torokhov wrote: > On Wed, Dec 15, 2010 at 03:25:27PM -0800, Alexey Dobriyan wrote: > > On Thu, Dec 16, 2010 at 12:14 AM, Dmitry Torokhov wrote: > > > On Wed, Dec 15, 2010 at 02:06:03PM -0800, Alexey Dobriyan wrote: > > >> On Thu, Dec 16, 2010 at 12:00 AM, Dmitry Torokhov wrote: > > >> > Currently only drivers that are built as modules have their versions > > >> > shown in /sys/module//version, but this information might > > >> > > >> Can you create just /sys/module/x? > > >> Module version info is quite useless by itself. > > > > > > It is as useful as in the case where driver is built as a module. I am > > > just trying to unify the behavior a bit. > > > > > > Code-wise it is almost as cheap to add /sys/module/x/version as adding > > > just the directory. > > > > OK. > > > > Still, people are using /sys/module/x presence as indicator of modular > > built (unsurprisingly). > > > > http://codesearch.google.com/codesearch/p?hl=en#wZuuyuB8jKQ/src/third_party/autotest/files/client/profilers/powertop/src/bluetooth.c&q=/sys/modules&sa=N&cd=3&ct=rc&l=105 > > Yeah, I hate to disappoint them but it will break as soon as someone > adds a module_param() to one of the objects... That's even without my > changes. Looking at this some more they are concerned whether bluetooth is present in the kernel, not whether it is loaded: if you care about power consumption you need to shut off BT interface whether BT core is a module or built-in. In this regard I'd say my change will make that code behave better ;) -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/