Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755005Ab0LPBwH (ORCPT ); Wed, 15 Dec 2010 20:52:07 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:55340 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288Ab0LPBwE convert rfc822-to-8bit (ORCPT ); Wed, 15 Dec 2010 20:52:04 -0500 MIME-Version: 1.0 In-Reply-To: <1292448616.3348.33.camel@odin> References: <20101215140344.GF5723@sirena.org.uk> <1292422225-27530-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1292448616.3348.33.camel@odin> Date: Thu, 16 Dec 2010 09:52:02 +0800 Message-ID: Subject: Re: [PATCH] regulator: Allow modular build of mc13xxx-core From: Yong Shen To: Liam Girdwood Cc: Mark Brown , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell , patches@opensource.wolfsonmicro.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1935 Lines: 57 Hi there, My bad. My test did not cover module-build case. Thanks for fixing this. Yong On Thu, Dec 16, 2010 at 5:30 AM, Liam Girdwood wrote: > On Wed, 2010-12-15 at 14:10 +0000, Mark Brown wrote: >> Since the MFD core for this device and the regulator drivers for these >> devices can be built modular we should also support modular build of >> the shared code for the regulator drivers, otherwise we try to link >> built in code against modular code with unfortunate results. >> >> Signed-off-by: Mark Brown > > Thanks Mark ! > > It looks like you sent the wrong patch as I had to also add :- > > diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c > index da46b3c..f53d31b 100644 > --- a/drivers/regulator/mc13xxx-regulator-core.c > +++ b/drivers/regulator/mc13xxx-regulator-core.c > @@ -89,6 +89,7 @@ int mc13xxx_regulator_list_voltage(struct regulator_dev *rdev, > > ? ? ? ?return mc13xxx_regulators[id].voltages[selector]; > ?} > +EXPORT_SYMBOL_GPL(mc13xxx_regulator_list_voltage); > > ?int mc13xxx_get_best_voltage_index(struct regulator_dev *rdev, > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?int min_uV, int max_uV) > @@ -232,6 +233,7 @@ int mc13xxx_sw_regulator_is_enabled(struct regulator_dev *rdev) > ?{ > ? ? ? ?return 1; > ?} > +EXPORT_SYMBOL_GPL(mc13xxx_sw_regulator_is_enabled); > > ?MODULE_LICENSE("GPL v2"); > ?MODULE_AUTHOR("Yong Shen "); > > To get it all building. > > Now applied and squashed with above. > > Liam > -- > Freelance Developer, SlimLogic Ltd > ASoC and Voltage Regulator Maintainer. > http://www.slimlogic.co.uk > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/