Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755461Ab0LPClw (ORCPT ); Wed, 15 Dec 2010 21:41:52 -0500 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:61631 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754974Ab0LPClv (ORCPT ); Wed, 15 Dec 2010 21:41:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAAsLCU15Lc+z/2dsb2JhbACkM3TBYIVKBA Date: Thu, 16 Dec 2010 13:41:46 +1100 From: Nick Piggin To: Peter =?iso-8859-1?Q?H=FCwe?= Cc: Stephen Rothwell , Nick Piggin , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] include/linux: Add missing include / fix build failure Message-ID: <20101216024146.GA3537@amd> References: <201012152204.18881.PeterHuewe@gmx.de> <20101216103141.6f0a418c.sfr@canb.auug.org.au> <201012160040.54313.PeterHuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201012160040.54313.PeterHuewe@gmx.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1957 Lines: 60 Hi Peter, Thanks for this. On Thu, Dec 16, 2010 at 12:40:54AM +0100, Peter H?we wrote: > From: Peter Huewe > > This patch fixes a build failure[1-2] by adding the missing asm/memory.h > include needed for arch_is_coherent(). > > Error message: > In file included from include/linux/list_bl.h:5, > from include/linux/rculist_bl.h:7, > from include/linux/dcache.h:7, > from include/linux/fs.h:381, > from arch/arm/mm/mmap.c:4: > include/linux/bit_spinlock.h: In function 'bit_spin_unlock': > include/linux/bit_spinlock.h:61: error: implicit declaration of function > 'arch_is_coherent' > > KernelVersion: linux-next-20101215 > Used configs: hackkit_defconfig (arm), ep93xx_defconfig (arm) > > References: > [1] http://kisskb.ellerman.id.au/kisskb/buildresult/3651495/ > [2] http://kisskb.ellerman.id.au/kisskb/buildresult/3651425/ > > Signed-off-by: Peter Huewe > --- > v2: > moved additional information in the commit message. > > include/linux/bit_spinlock.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h > index e612575..053fad7 100644 > --- a/include/linux/bit_spinlock.h > +++ b/include/linux/bit_spinlock.h > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > > /* > * bit-based spin_lock() The problem is actually in ARM's asm/atomic.h file -- they declare the smp_mb__before_clear_bit() etc. without providing the necessary includes to actually call it. Can you include asm/memory.h in there? Thanks, Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/