Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756112Ab0LPPvW (ORCPT ); Thu, 16 Dec 2010 10:51:22 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:60418 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683Ab0LPPvU (ORCPT ); Thu, 16 Dec 2010 10:51:20 -0500 Date: Thu, 16 Dec 2010 07:51:11 -0800 From: "Paul E. McKenney" To: Mariusz Kozlowski Cc: Dipankar Sarma , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rculist: fix borked __list_for_each_rcu() macro Message-ID: <20101216155111.GC2203@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1292451072-5095-1-git-send-email-mk@lab.zgora.pl> <20101215232005.GB6595@linux.vnet.ibm.com> <20101216060236.GB4826@mako-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101216060236.GB4826@mako-laptop> User-Agent: Mutt/1.5.20 (2009-06-14) X-Content-Scanned: Fidelis XPS MAILER Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1959 Lines: 53 On Thu, Dec 16, 2010 at 07:02:36AM +0100, Mariusz Kozlowski wrote: > On Wed, Dec 15, 2010 at 03:20:05PM -0800, Paul E. McKenney wrote: > > On Wed, Dec 15, 2010 at 11:11:12PM +0100, Mariusz Kozlowski wrote: > > > This restores parentheses blance. > > > > Good catch, queued!!! > > > > This does not actually appear to be in use anywhere in the kernel any > > more, so I queued this for 2.6.38 rather than in the 2.6.37 urgent queue. > > So, just out of curiosity, how did you find this one? > > Some years ago I wrote a dumb script that walks trees of () and {}. > It catches unbalanced trees. It's dumb enough to fail with #ifdef etc, > but most of the time it does its job. It reaches unreachable code > and unused one too. Very cool, and thank you! Thanx, Paul > > Hmmm... Maybe we should just delete __list_for_each_rcu. ;-) > > > > Thanx, Paul > > > > > Signed-off-by: Mariusz Kozlowski > > > --- > > > include/linux/rculist.h | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/include/linux/rculist.h b/include/linux/rculist.h > > > index f31ef61..70d3ba5 100644 > > > --- a/include/linux/rculist.h > > > +++ b/include/linux/rculist.h > > > @@ -244,7 +244,7 @@ static inline void list_splice_init_rcu(struct list_head *list, > > > #define __list_for_each_rcu(pos, head) \ > > > for (pos = rcu_dereference_raw(list_next_rcu(head)); \ > > > pos != (head); \ > > > - pos = rcu_dereference_raw(list_next_rcu((pos))) > > > + pos = rcu_dereference_raw(list_next_rcu(pos))) > > > > > > /** > > > * list_for_each_entry_rcu - iterate over rcu list of given type > > > -- > > > 1.7.0.4 > > > > > -- > Mariusz Kozlowski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/