Date: Thu, 16 Dec 2010 16:26:10 -0500
From: Dave Jones <davej@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: warn if registering world writeable files
Message-ID: <20101216212609.GA9352@redhat.com>
Mail-Followup-To: Dave Jones <davej@redhat.com>,
	Alexey Dobriyan <adobriyan@gmail.com>, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
References: <20101216203217.GA3581@p183.telecom.by>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101216203217.GA3581@p183.telecom.by>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1114
Lines: 31

On Thu, Dec 16, 2010 at 10:32:17PM +0200, Alexey Dobriyan wrote:
 > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
 > ---
 > 
 >  fs/proc/generic.c |    1 +
 >  1 file changed, 1 insertion(+)
 > 
 > --- a/fs/proc/generic.c
 > +++ b/fs/proc/generic.c
 > @@ -623,6 +623,7 @@ static struct proc_dir_entry *__proc_create(struct proc_dir_entry **parent,
 >  	memcpy(((char *) ent) + sizeof(struct proc_dir_entry), fn, len + 1);
 >  	ent->name = ((char *) ent) + sizeof(*ent);
 >  	ent->namelen = len;
 > +	WARN_ON(S_ISREG(mode) && (mode & S_IWOTH));
 >  	ent->mode = mode;
 >  	ent->nlink = nlink;
 >  	atomic_set(&ent->count, 1);

Not sure about this. For the reason I mentioned in the checkpatch diff
that this is "usually" a problem.  There may be some use cases where
it may actually be ok.

(I'm having a hard time thinking up a justification though tbh)

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/