Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753982Ab0LQAE3 (ORCPT ); Thu, 16 Dec 2010 19:04:29 -0500 Received: from kroah.org ([198.145.64.141]:53533 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877Ab0LQAE1 (ORCPT ); Thu, 16 Dec 2010 19:04:27 -0500 Date: Thu, 16 Dec 2010 16:02:02 -0800 From: Greg KH To: Jef Driesen Cc: Robert Lukassen , David Brownell , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: g_serial: Allow to override the default VID/PID Message-ID: <20101217000202.GA29844@kroah.com> References: <4CE6F807.1090607@telenet.be> <1290209554-7026-1-git-send-email-jefdriesen@telenet.be> <20101120001247.GB17421@kroah.com> <4CE853BF.80504@telenet.be> <20101130174605.GC19977@kroah.com> <4CF96A9D.8070800@telenet.be> <4D0874FB.8080503@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D0874FB.8080503@telenet.be> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 21 On Wed, Dec 15, 2010 at 08:57:47AM +0100, Jef Driesen wrote: > On 06/12/10 09:09, Robert Lukassen wrote: > >Yes, providing access to those module parameters was the original goal. I > >agree that my patch should be reverted and I'll try to come up with a method > >of accessing these values without violating the information hiding principles > >too much. I don't like accessing globals. > > Do I have to take any action to make sure the original commit [1] gets reverted? > > [1] 1ab83238740ff1e1773d5c13ecac43c60cf4aec4 It's now reverted. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/