Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164Ab0LQCKQ (ORCPT ); Thu, 16 Dec 2010 21:10:16 -0500 Received: from smtp-out.google.com ([216.239.44.51]:45873 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751867Ab0LQCKN (ORCPT ); Thu, 16 Dec 2010 21:10:13 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=TsYH1QUpMjS6qFJz9nnNXG6nVuEV5YIxuRbBZoc+4c8OZV5N7jifOb69gKSCyp1zZ3 faH9qNKFWanROkmuwi0A== Date: Thu, 16 Dec 2010 18:10:02 -0800 (PST) From: Hugh Dickins X-X-Sender: hughd@tigran.mtv.corp.google.com To: Minchan Kim cc: Miklos Szeredi , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: add replace_page_cache_page() function In-Reply-To: Message-ID: References: <20101216220457.GA3450@barrios-desktop> User-Agent: Alpine 2.00 (LSU 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 28 On Fri, 17 Dec 2010, Minchan Kim wrote: > On Fri, Dec 17, 2010 at 10:21 AM, Hugh Dickins wrote: > > > > I disagree with you there: I like the way Miklos made it symmetric, > > I like the way delete_from_swap_cache drops the swap cache reference, > > I dislike the way remove_from_page_cache does not - I did once try to > > change that, but did a bad job, messed up reiserfs or reiser4 I forget > > which, retreated in shame. > > I agree symmetric is good. I just said current fact which is that > remove_from_page_cache doesn't release ref. > So I thought we have to match current semantic to protect confusing. > Okay. I will not oppose current semantics. > Instead of it, please add it (ex, caller should hold the page > reference) in function description. > > I am happy to hear that you tried it. > Although it is hard, I think it's very valuable thing. > Could you give me hint to googling your effort and why it is failed? http://lkml.org/lkml/2004/10/24/140 Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/